[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] python: add .gitignore

From: John Snow
Subject: Re: [PATCH 4/5] python: add .gitignore
Date: Wed, 28 Oct 2020 09:39:07 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/28/20 5:16 AM, Markus Armbruster wrote:
Thomas Huth <thuth@redhat.com> writes:

On 27/10/2020 23.38, John Snow wrote:
Ignore build and package output (build, dist, qemu.egg-info);
effectively these are "in-tree" builds of a kind.

Since we recently moved away from in-tree builds, could these also be made
out-of-tree only?

The build should only write to the per-build spaces: the build tree,
per-build scratch in /tmp, ...  Writing to shared space such as the
source tree can break parallel independent builds.  I consider that a

It's not really a "build" in that traditional sense, but if you were to execute "make venv-check" in parallel, I'm not confident it would work right. Don't do that, I guess.

This has nothing to do with QEMU's build step. We don't need to "build" or "install" this package to use it during QEMU builds or (most) testing. We *do* need to install it to a virtual environment to test it with an explicit set of linter packages, though.

See also: why do we ignore *.pyc and __pycache__ files in the whole tree? These are in effect build artifacts too. I'm not sure I would know how to avoid those being created. Maybe it's possible? but... I don't think this is a problem that we have to solve, actually.

OK, all that whining aside, I will give it a legitimate try. I just wanted to prepare you for disappointment. I might be able to move build/ and dist/, but I have doubts that anything can reasonably be done about qemu.egg-info, __pycache__, .mypy_cache, or the like.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]