[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] python: add excluded dirs to flake8 config

From: John Snow
Subject: Re: [PATCH 2/5] python: add excluded dirs to flake8 config
Date: Wed, 28 Oct 2020 09:42:36 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/28/20 4:50 AM, Philippe Mathieu-Daudé wrote:
On 10/27/20 11:38 PM, John Snow wrote:
Following patches make obvious that we ought to ignore certain
directories to avoid wildly erroneous flake8 output.

Signed-off-by: John Snow <jsnow@redhat.com>
  python/setup.cfg | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/python/setup.cfg b/python/setup.cfg
index cb696291ba38..d0ad683b5148 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -30,6 +30,8 @@ devel =
  extend-ignore = E722  # Prefer pylint's bare-except checks to flake8's
+exclude = __pycache__,
+          .venv,

Can we make flake8 aware the files are in a git repository instead?

Long story short, no.

Python tooling copies source out of git for many reasons -- during installation, packaging, etc -- and it loses git metadata.

This is why I have a VERSION file in this directory, too. I have no access to the git tags from within the python packaging ecosystem.


Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

  strict = True

reply via email to

[Prev in Thread] Current Thread [Next in Thread]