[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable

From: BALATON Zoltan
Subject: Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable
Date: Mon, 25 Jan 2021 20:50:23 +0100 (CET)

On Mon, 25 Jan 2021, Stefan Hajnoczi wrote:
Zoltan reminded me that the 'log' backend prints tids/timestamps and this can
be unwanted in some cases. It's easier to look at trace output without them and
in some cases parsing is also more convenient with them.

Extend -msg timestamp=on|off to control the 'log' backend's tid/timestamp 

Thank you, this works for me

Tested-by: BALATON Zoltan <balaton@eik.bme.hu>

but I had to remove build dir and rerun configure to get it omit timestamps. Just running make (which reruns configure) or make distclean and running configure does not seem to be enough to pick up some changes since the meson conversion. (I had similar problem with gtk being detected and used despite having --disable-gtk on configure before the gtk test was moved to meson; so I think there's some problem detecting changes in configure options somewhere. That was also fixed by rerunning configure after starting from clean build dir but did not work when keeping old build dir or make distclean. This is probably not a problem for someone downloading the sources and compiling it once, only annoying for developers who build it all the time.)


Stefan Hajnoczi (2):
 error: rename error_with_timestamp to message_with_timestamp
 trace: make the 'log' backend timestamp configurable

docs/devel/tracing.txt           |  3 +++
include/qemu/error-report.h      |  2 +-
softmmu/vl.c                     |  2 +-
util/qemu-error.c                |  4 ++--
scripts/tracetool/backend/log.py | 19 +++++++++++++------
5 files changed, 20 insertions(+), 10 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]