[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable |
Date: |
Mon, 25 Jan 2021 15:06:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
Hi Stefan,
On 1/25/21 12:35 PM, Stefan Hajnoczi wrote:
> Zoltan reminded me that the 'log' backend prints tids/timestamps and this can
> be unwanted in some cases. It's easier to look at trace output without them
> and
> in some cases parsing is also more convenient with them.
>
> Extend -msg timestamp=on|off to control the 'log' backend's tid/timestamp
> output.
>
> Stefan Hajnoczi (2):
> error: rename error_with_timestamp to message_with_timestamp
> trace: make the 'log' backend timestamp configurable
>
> docs/devel/tracing.txt | 3 +++
> include/qemu/error-report.h | 2 +-
> softmmu/vl.c | 2 +-
> util/qemu-error.c | 4 ++--
> scripts/tracetool/backend/log.py | 19 +++++++++++++------
> 5 files changed, 20 insertions(+), 10 deletions(-)
I applied your series, rebuilt, but nothing changed.
Apparently there is some buildsys rule missing, the
trace files weren't regenerated.
After full tree 'make clean' I could successfully test:
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Ignoring the buildsys issue:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Regards,
Phil.