[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 22/23] target/i386: fix host_cpu_adjust_phys_bits error h
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v16 22/23] target/i386: fix host_cpu_adjust_phys_bits error handling |
|
Date: |
Fri, 5 Feb 2021 10:15:42 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/4/21 6:39 AM, Claudio Fontana wrote:
> move the check for phys_bits outside of host_cpu_adjust_phys_bits,
> because otherwise it is impossible to return an error condition
> explicitly.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/i386/host-cpu.c | 22 ++++++++++++----------
> 1 file changed, 12 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v16 07/23] cpu: Move debug_excp_handler to tcg_ops, (continued)
- [PATCH v16 07/23] cpu: Move debug_excp_handler to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 08/23] target/arm: do not use cc->do_interrupt for KVM directly, Claudio Fontana, 2021/02/04
- [PATCH v16 09/23] cpu: move cc->do_interrupt to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 10/23] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 13/23] cpu: move adjust_watchpoint_address to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 11/23] cpu: move do_unaligned_access to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 12/23] physmem: make watchpoint checking code TCG-only, Claudio Fontana, 2021/02/04
- [PATCH v16 16/23] accel: extend AccelState and AccelClass to user-mode, Claudio Fontana, 2021/02/04
- [PATCH v16 20/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/02/04
- [PATCH v16 22/23] target/i386: fix host_cpu_adjust_phys_bits error handling, Claudio Fontana, 2021/02/04
- Re: [PATCH v16 22/23] target/i386: fix host_cpu_adjust_phys_bits error handling,
Richard Henderson <=
- [PATCH v16 21/23] accel: introduce new accessor functions, Claudio Fontana, 2021/02/04
[PATCH v16 18/23] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2021/02/04
[PATCH v16 14/23] cpu: move debug_check_watchpoint to tcg_ops, Claudio Fontana, 2021/02/04
[PATCH v16 15/23] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass, Claudio Fontana, 2021/02/04
[PATCH v16 17/23] accel: replace struct CpusAccel with AccelOpsClass, Claudio Fontana, 2021/02/04