[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 21/23] accel: introduce new accessor functions
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v16 21/23] accel: introduce new accessor functions |
Date: |
Mon, 8 Feb 2021 13:54:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/8/21 1:50 PM, Claudio Fontana wrote:
> On 2/5/21 9:14 PM, Richard Henderson wrote:
>> On 2/4/21 6:39 AM, Claudio Fontana wrote:
>>> @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj)
>>> x86_cpu_load_model(cpu, xcc->model);
>>> }
>>>
>>> - /* if required, do the accelerator-specific cpu initialization */
>>> - if (cc->accel_cpu) {
>>> - cc->accel_cpu->cpu_instance_init(CPU(obj));
>>> - }
>>> + /* if required, do accelerator-specific cpu initializations */
>>> + accel_cpu_instance_init(CPU(obj));
>>> }
>>
>> Why is this only done for x86?
>>
>>
>> r~
>>
>
> It makes sense to include the other architectures.
>
> As the next step I would like to apply this to ARM, but to me it makes sense
> to first complete Philippe's series,
> which reshuffles things so that TCG-only / KVM-only builds are both possible
> and error-free:
>
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg777627.html
TBH this series is very unlikely to be merged before yours,
so go ahead... (eventually you can cherry-pick what you need
from it).
- [PATCH v16 13/23] cpu: move adjust_watchpoint_address to tcg_ops, (continued)
- [PATCH v16 13/23] cpu: move adjust_watchpoint_address to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 11/23] cpu: move do_unaligned_access to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 12/23] physmem: make watchpoint checking code TCG-only, Claudio Fontana, 2021/02/04
- [PATCH v16 16/23] accel: extend AccelState and AccelClass to user-mode, Claudio Fontana, 2021/02/04
- [PATCH v16 20/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/02/04
- [PATCH v16 22/23] target/i386: fix host_cpu_adjust_phys_bits error handling, Claudio Fontana, 2021/02/04
- [PATCH v16 21/23] accel: introduce new accessor functions, Claudio Fontana, 2021/02/04
[PATCH v16 18/23] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2021/02/04
[PATCH v16 14/23] cpu: move debug_check_watchpoint to tcg_ops, Claudio Fontana, 2021/02/04
[PATCH v16 15/23] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass, Claudio Fontana, 2021/02/04
[PATCH v16 17/23] accel: replace struct CpusAccel with AccelOpsClass, Claudio Fontana, 2021/02/04
[PATCH v16 19/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2021/02/04
[PATCH v16 23/23] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/02/04