Re: [RFC PATCH 08/42] target/mips/tx79: Move MFHI1 / MFLO1 opcodes to decodetree

[Richard Henderson]

On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote:
> Introduce decodetree structure to decode the tx79 opcodes.
> Start it by moving the existing MFHI1 and MFLO1 opcodes.
> Remove unnecessary comments.
> 
> As the TX79 share opcodes with the TX19/TX39/TX49 CPUs,
> we introduce the decode_ext_txx9() dispatcher where we
> will add the other decoders later.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/mips/translate.h      |  4 ++++
>  target/mips/tx79.decode      | 25 ++++++++++++++++++++++++
>  target/mips/translate.c      | 15 +++------------
>  target/mips/tx79_translate.c | 37 ++++++++++++++++++++++++++++++++++++
>  target/mips/txx9_translate.c | 20 +++++++++++++++++++
>  target/mips/meson.build      |  5 +++++
>  6 files changed, 94 insertions(+), 12 deletions(-)
>  create mode 100644 target/mips/tx79.decode
>  create mode 100644 target/mips/tx79_translate.c
>  create mode 100644 target/mips/txx9_translate.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~