Re: [PATCH 14/22] Acceptance Tests: introduce LinuxTest base class

[Willian Rampazzo]

On Wed, Feb 3, 2021 at 2:24 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> This is basically the infrastructure around "boot_linux.py" tests, but
> now made into a base class for general use.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/acceptance/avocado_qemu/__init__.py | 87 +++++++++++++++++++++
>  tests/acceptance/boot_linux.py            | 94 ++---------------------
>  tests/acceptance/virtiofs_submounts.py    |  6 +-
>  3 files changed, 94 insertions(+), 93 deletions(-)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py 
> b/tests/acceptance/avocado_qemu/__init__.py
> index bf54e419da..b06692a59d 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py

I found it not so intuitive to have the base class defined here. I see
the number of base classes for the tests growing in the future. A
common place for base classes for tests would be better, just like the
`qemu.utils` you are defining somewhere else. Anyway, this is a design
decision that can be changed later, so

Reviewed-by: Willian Rampazzo <willianr@redhat.com>