[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gitlab-ci: Remove unused container images
From: |
Alex Bennée |
Subject: |
Re: [PATCH] gitlab-ci: Remove unused container images |
Date: |
Mon, 22 Feb 2021 08:44:47 +0000 |
User-agent: |
mu4e 1.5.8; emacs 28.0.50 |
Thomas Huth <thuth@redhat.com> writes:
> On 20/02/2021 22.10, Alex Bennée wrote:
>>
>> Thomas Huth <thuth@redhat.com> writes:
>>
>>> We're building a lot of containers in the gitlab-CI that we never use.
>>> This takes away network bandwidth and CPU time from other jobs for no
>>> use, so let's remove them for now. The individual containers could be
>>> re-added later when we really need them.
>>
>> They are used - when people run check-tcg their builds are cached via
>> gitlab.
>
> Oh, I didn't know that. But where's the magic that tells the tcg tests to
> use the registry from gitlab?
> "grep -ri gitlab tests/tcg" does not show any results?
It's in the docker makefiles:
DOCKER_REGISTRY := $(if
$(REGISTRY),$(REGISTRY),registry.gitlab.com/qemu-project/qemu)
which are dependencies for the appropriate tests.
> Also some documentation would be helpful, docs/devel/testing.rst does not
> talk about gitlab at all...?
I'll see if I can improve that.
>
> Thomas
--
Alex Bennée