[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gitlab-ci: Remove unused container images

From: Alex Bennée
Subject: Re: [PATCH] gitlab-ci: Remove unused container images
Date: Sat, 20 Feb 2021 21:11:44 +0000
User-agent: mu4e 1.5.8; emacs 28.0.50

Thomas Huth <thuth@redhat.com> writes:

> On 19/02/2021 13.00, Philippe Mathieu-Daudé wrote:
>> On 2/19/21 12:09 PM, Thomas Huth wrote:
>>> We're building a lot of containers in the gitlab-CI that we never use.
>>> This takes away network bandwidth and CPU time from other jobs for no
>>> use, so let's remove them for now. The individual containers could be
>>> re-added later when we really need them.
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   .gitlab-ci.d/containers.yml | 92 -------------------------------------
>>>   1 file changed, 92 deletions(-)
>> I'm not enthusiast with this patch because I use various in this list
>> from time to time for testing or cross build/disas binaries.
> When I look at our current huge list of containers, I wonder how do we know 
> which containers still get used (in the sense of not only build), and which 
> ones are likely already bit-rotten? And why do we need that many containers? 
> Why both, debian-arm64-test-cross.docker and debian-arm64-cross.docker and 
> not combine them?

debian64-arm64-test-cross is based of testing because we need a newer
GCC than the QEMU cross compiler to build the SVE and MTE tests for
aarch64 check-tcg.

> And why do we need that many individual cross-compiler 
> docker files if we already have debian-all-test-cross.docker that can be 
> used to test most of them? ... for me, as a docker ignorant, this is all 
> very opaque and some clean up IMHO could really help here.

Because it's quite heavyweight for users who may only be building one or
two arches to pull down all the compilers in one image.

>> Not having
>> these containers used mainstream probably show the failure of the
>> project to add good testing coverage on these targets. Most of them are
>> for hobbyist with little time. Removing them will make it even harder
>> to add tests.
> Do you really use the docker files from the gitlab registry? I'd rather 
> expected that people build those locally in case they need them...?
>> Can't we keep them disabled? Or put them in manual mode?
> Well, I guess manual mode is fine, too, as long as they don't waste CPU 
> cycles and network bandwidth anymore for most people who don't need them.
>   Thomas

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]