Re: [PATCH v22 17/17] i386: move cpu_load_efer into sysemu-only section of cpu.h

[Richard Henderson]

On 2/24/21 5:34 AM, Claudio Fontana wrote:
> cpu_load_efer is now used only for sysemu code.
> 
> Therefore, make this inline function not visible anymore
> in CONFIG_USER_ONLY builds.
> 
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
>  target/i386/cpu.h | 31 ++++++++++++++++---------------
>  1 file changed, 16 insertions(+), 15 deletions(-)

Perhaps move to cpu-internal.h?  It is not used outside of target/i386/.

Or declared in cpu-internal.h and placed in cpu-sysemu.c?  I don't see that
it's particularly performance sensitive either.

But one way or the other,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~