[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/24] hw/misc/mps2-fpgaio: Make number of LEDs configurab

From: Richard Henderson
Subject: Re: [PATCH v2 05/24] hw/misc/mps2-fpgaio: Make number of LEDs configurable by board
Date: Sun, 28 Feb 2021 19:04:24 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 2/15/21 3:51 AM, Peter Maydell wrote:
The MPS2 board has 2 LEDs, but the MPS3 board has 10 LEDs.  The
FPGAIO device is similar on both sets of boards, but the LED0
register has correspondingly more bits that have an effect.  Add a
device property for number of LEDs.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
  include/hw/misc/mps2-fpgaio.h |  5 ++++-
  hw/misc/mps2-fpgaio.c         | 31 +++++++++++++++++++++++--------
  2 files changed, 27 insertions(+), 9 deletions(-)

Similar comment with 'int i' / 'uint32_t num_leds'.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]