[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/11] target/cris: Replace DISAS_TB_JUMP with DISAS_NORET
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 02/11] target/cris: Replace DISAS_TB_JUMP with DISAS_NORETURN |
|
Date: |
Mon, 21 Jun 2021 22:01:17 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/20/21 11:32 PM, Richard Henderson wrote:
> The only semantic of DISAS_TB_JUMP is that we've done goto_tb,
> which is the same as DISAS_NORETURN -- we've exited the tb.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/cris/translate.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index bed7a7ed10..2ff4319dd1 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -55,7 +55,6 @@
> /* is_jmp field values */
> #define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */
> #define DISAS_UPDATE DISAS_TARGET_1 /* cpu state was modified dynamically */
> -#define DISAS_TB_JUMP DISAS_TARGET_2 /* only pc was modified statically */
> #define DISAS_SWI DISAS_TARGET_3
Can we #define DISAS_SWI DISAS_TARGET_2 in the same commit?
- [PATCH v2 00/11] target/cris: Convert to TranslatorOps, Richard Henderson, 2021/06/20
- [PATCH v2 01/11] target/cris: Add DisasContextBase to DisasContext, Richard Henderson, 2021/06/20
- [PATCH v2 03/11] target/cris: Mark exceptions as DISAS_NORETURN, Richard Henderson, 2021/06/20
- [PATCH v2 05/11] target/cris: Fix use_goto_tb, Richard Henderson, 2021/06/20
- [PATCH v2 02/11] target/cris: Replace DISAS_TB_JUMP with DISAS_NORETURN, Richard Henderson, 2021/06/20
- Re: [PATCH v2 02/11] target/cris: Replace DISAS_TB_JUMP with DISAS_NORETURN,
Philippe Mathieu-Daudé <=
- [PATCH v2 04/11] target/cris: Remove DISAS_SWI, Richard Henderson, 2021/06/20
- [PATCH v2 07/11] target/cris: Mark helper_raise_exception noreturn, Richard Henderson, 2021/06/20
- [PATCH v2 08/11] target/cris: Mark static arrays const, Richard Henderson, 2021/06/20
- [PATCH v2 09/11] target/cris: Move delayed branch handling to tb_stop, Richard Henderson, 2021/06/20
- [PATCH v2 06/11] target/cris: Convert to TranslatorOps, Richard Henderson, 2021/06/20
- [PATCH v2 10/11] target/cris: Use tcg_gen_lookup_and_goto_ptr, Richard Henderson, 2021/06/20