Re: [PATCH v2 08/11] target/cris: Mark static arrays const

[Philippe Mathieu-Daudé]

On 6/20/21 11:32 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/cris/translate.c         | 19 ++++++++++---------
>  target/cris/translate_v10.c.inc |  6 +++---
>  2 files changed, 13 insertions(+), 12 deletions(-)

>  #if DISAS_CRIS
>  static const char *cc_name(int cc)
>  {
> -    static const char *cc_names[16] = {
> +    static const char * const cc_names[16] = {

char [2]?

>          "cc", "cs", "ne", "eq", "vc", "vs", "pl", "mi",
>          "ls", "hi", "ge", "lt", "gt", "le", "a", "p"
>      };

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>