[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hvf: arm: Ignore cache operations on MMIO
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2] hvf: arm: Ignore cache operations on MMIO |
Date: |
Tue, 2 Nov 2021 10:42:42 +0000 |
On Tue, 2 Nov 2021 at 10:01, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 11/1/21 3:35 PM, Peter Maydell wrote:
> > On Mon, 1 Nov 2021 at 19:28, Richard Henderson
> > <richard.henderson@linaro.org> wrote:
> >>
> >> On 10/26/21 3:12 AM, Alexander Graf wrote:
> >>> Apple's Hypervisor.Framework forwards cache operations as MMIO traps
> >>> into user space. For MMIO however, these have no meaning: There is no
> >>> cache attached to them.
> >>>
> >>> So let's just treat cache data exits as nops.
> >>>
> >>> This fixes OpenBSD booting as guest.
> >>>
> >>> Signed-off-by: Alexander Graf <agraf@csgraf.de>
> >>> Reported-by: AJ Barris <AwlsomeAlex@github.com>
> >>> Reference: https://github.com/utmapp/UTM/issues/3197
> >>> ---
> >>> target/arm/hvf/hvf.c | 7 +++++++
> >>> 1 file changed, 7 insertions(+)
> >>
> >> Thanks, applied to target-arm.next
> >
> > ...did you see my email saying I think we also need
> > to test S1PTW ?
>
> That arrived afterward.
Thinking it over later, I wouldn't be opposed to taking this
patch now and adding the S1PTW second -- I think we're
currently going to do the wrong thing for the "page tables
not in RAM case anyway", so you could regard it as a
separate bug fix.
-- PMM
Re: [PATCH v2] hvf: arm: Ignore cache operations on MMIO, Peter Maydell, 2021/11/01
Re: [PATCH v2] hvf: arm: Ignore cache operations on MMIO, Peter Maydell, 2021/11/01