|
From: | Paolo Bonzini |
Subject: | Re: Add TCG support for UMIP |
Date: | Mon, 7 Feb 2022 10:11:57 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 |
On 2/6/22 21:27, Gareth Webb wrote:
@@ -7382,6 +7383,8 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu) case 0: /* sldt */ if (!PE(s) || VM86(s)) goto illegal_op; + if ((PE(s) || LMA(s)) && s->cpuid_7_0_ecx_features & CPUID_7_0_ECX_UMIP && s->flags & HF_UMIP_MASK)
No need to check CPUID here (and below). If the bit is clear, HF_UMIP_MASK won't be set.
Otherwise looks good, thanks! Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |