[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] hw: aspeed_gpio: Model new interface for the AST2600
|
From: |
Andrew Jeffery |
|
Subject: |
Re: [PATCH 0/3] hw: aspeed_gpio: Model new interface for the AST2600 |
|
Date: |
Wed, 09 Feb 2022 21:39:36 +1030 |
|
User-agent: |
Cyrus-JMAP/3.5.0-alpha0-4748-g31a5b5f50e-fm-cal2020-20220204.001-g31a5b5f5 |
On Tue, 8 Feb 2022, at 01:34, Andrew Jeffery wrote:
> Hello,
>
> This series adds support for a new register interface supported by the
> Aspeed GPIO controller, present in at least the AST2600.
>
> The new interface is a single register implementing an indirect command
> protocol that allows us to manipulate up to (at least) 208 GPIOs. This
> makes it possible to write very simple drivers for e.g. u-boot and
> jettison the need for the tedious data model required to deal with the
> old register layout.
>
> I've lightly tested the device consistency under Linux. The Linux
> driver is implemented in terms of the old interface, so data model
> consistency can be tested one way by poking the driver using the
> libgpiod tools and then the other using devmem to drive the new
> interface.
>
> Please review!
Naturally further testing revealed some quirks that require further
enhancements to the modelling.
Hold off on doing anything with this series for the moment.
Cheers,
Andrew