Re: [PATCH v6 18/19] vfio-user: handle reset of remote device

[Stefan Hajnoczi]

On Mon, Mar 07, 2022 at 03:37:51PM +0000, Jag Raman wrote:
> 
> 
> > On Mar 7, 2022, at 6:36 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > 
> > On Thu, Feb 17, 2022 at 02:49:05AM -0500, Jagannathan Raman wrote:
> >> Adds handler to reset a remote device
> >> 
> >> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> >> Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
> >> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
> >> ---
> >> hw/remote/vfio-user-obj.c | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >> 
> >> diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c
> >> index 2304643003..55f1bf5e0f 100644
> >> --- a/hw/remote/vfio-user-obj.c
> >> +++ b/hw/remote/vfio-user-obj.c
> >> @@ -989,6 +989,19 @@ static bool vfu_object_migratable(VfuObject *o)
> >>     return dc->vmsd && !dc->vmsd->unmigratable;
> >> }
> >> 
> >> +static int vfu_object_device_reset(vfu_ctx_t *vfu_ctx, vfu_reset_type_t 
> >> type)
> >> +{
> >> +    VfuObject *o = vfu_get_private(vfu_ctx);
> >> +
> >> +    if (type == VFU_RESET_LOST_CONN) {
> >> +        return 0;
> >> +    }
> > 
> > Why is a lost connection ignored? Should there be a QMP monitor event?
> 
> We handle the lost connection case in vfu_object_ctx_run(), which is in
> PATCH 5 of this series. We are sending a QMP monitor event in this case.

Great, please add a comment here.

Stefan

signature.asc
Description: PGP signature