Re: [RFC PATCH 17/27] target/arm: Extract cpustate list manipulation to a file

[Richard Henderson]

On 1/4/23 13:58, Fabiano Rosas wrote:
> This code doesn't need to be buried in helper.c. Let's move it to its
> own file to keep things cleaner.
>
> Code moved verbatim.
>
> Signed-off-by: Fabiano Rosas<farosas@suse.de>
> ---
> Extracted from:
> https://lore.kernel.org/r/20210416162824.25131-15-cfontana@suse.de
> [RFC v14 14/80] target/arm: split cpregs from tcg/helper.c
> ---
>   target/arm/cpregs.h        |   5 ++
>   target/arm/cpustate-list.c | 148 +++++++++++++++++++++++++++++++++++++
>   target/arm/helper.c        | 136 ----------------------------------
>   target/arm/meson.build     |   1 +
>   4 files changed, 154 insertions(+), 136 deletions(-)
>   create mode 100644 target/arm/cpustate-list.c

I'd rather the new file be called cpregs.c, to match the header.
I've been thinking about moving all of that code out of helper.c...

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~