qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/5] hw/char/pl011: implement a reset method


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 3/5] hw/char/pl011: implement a reset method
Date: Mon, 23 Jan 2023 08:25:27 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 20/1/23 16:54, Evgeny Iakovlev wrote:
PL011 currently lacks a reset method. Implement it.

Signed-off-by: Evgeny Iakovlev <eiakovlev@linux.microsoft.com>
---
  hw/char/pl011.c | 26 +++++++++++++++++++++-----
  1 file changed, 21 insertions(+), 5 deletions(-)

  static void pl011_class_init(ObjectClass *oc, void *data)
  {
      DeviceClass *dc = DEVICE_CLASS(oc);
dc->realize = pl011_realize;
+    dc->reset = pl011_reset;
Maybe directly implement as ResettableHoldPhase from "hw/resettable.h".

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]