Re: [PATCH v5 13/36] tcg: Add temp allocation for TCGv_i128

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> This enables allocation of i128.  The type is not yet
> usable, as we have not yet added data movement ops.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/tcg/tcg.h | 32 +++++++++++++++++++++++++
>  tcg/tcg.c         | 60 +++++++++++++++++++++++++++++++++--------------
>  2 files changed, 74 insertions(+), 18 deletions(-)
>
> diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
> index 8b7e61e7a5..7a8e4bbdd7 100644
> --- a/include/tcg/tcg.h
> +++ b/include/tcg/tcg.h
> @@ -685,6 +685,11 @@ static inline TCGTemp *tcgv_i64_temp(TCGv_i64 v)
>      return tcgv_i32_temp((TCGv_i32)v);
>  }
>  
> +static inline TCGTemp *tcgv_i128_temp(TCGv_i128 v)
> +{
> +    return tcgv_i32_temp((TCGv_i32)v);
> +}
> +

Why do we have all these different allocate functions if TCGTemp's are a
shared abstract type anyway?

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro