[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 14/19] openpic: convert to qdev

From: Alexander Graf
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 14/19] openpic: convert to qdev
Date: Tue, 11 Dec 2012 09:25:31 +0100

On 11.12.2012, at 00:47, Scott Wood <address@hidden> wrote:

> On 12/08/2012 07:44:37 AM, Alexander Graf wrote:
>> This patch converts the OpenPIC device to qdev. Along the way it
>> renames the "openpic" target to "raven" and the "mpic" target to
>> "mpc8544", to better reflect the actual models they implement.
>> This way we have a generic OpenPIC device now that can handle
>> different flavors of the OpenPIC specification.
> I'd rather not see the expansion of "mpc8544" hardcoding, especially since 
> it's not really modelling an MPIC as found in an mpc8544, but rather 
> half-implementing a generic Freescale MPIC.  

That's what we've been doing wrong all the time now. We shouldn't implement a 
half-generic fsl mpic, because we will never get to a point where we're 
accurate enough or flexible enough for both definitions.

If we want a pv style generic mpic (for -M e500), let's add such an mpic to the 
model list and make that one be really generic. But the MPIC in -M mpc8544ds 
should behave exactly like an mpc8544 mpic. Whenever we fail to do so, we 
better fix the emulation to be accurate ;)

> Can we just call it a Freescale MPIC, and then work on parameterizing it 
> properly (starting with MPIC version)?

We can add a generic fsl mpic if you like. We can also extract commonalities 
between the generic fsl mpic and the mpc8544 mpic into a function inside 

The MPIC version is a parameter after this patch set, but it's an internal 
parameter. My first version of the qdevification was setting all the openpic 
parameters from the machine file, so that you could assemble whatever openpic 
you like by setting the currect parameters.

That approach is overkill though. We are working in an open source world, where 
you can always just modify openpic.c, addd your model and be happy :)

Thanks a lot for the review btw!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]