[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 02/19] mpic: Unify numbering scheme

From: Scott Wood
Subject: Re: [Qemu-ppc] [PATCH 02/19] mpic: Unify numbering scheme
Date: Tue, 11 Dec 2012 11:39:51 -0600

On 12/11/2012 02:14:42 AM, Alexander Graf wrote:

On 11.12.2012, at 00:34, Scott Wood <address@hidden> wrote:

> On 12/08/2012 07:44:25 AM, Alexander Graf wrote:
>> +/* These are available through separate regions, but
>> +   for simplicity's sake mapped into the same number space */
>> +#define MPIC_TMR_IRQ      0xf3
>> +#define MPIC_IPI_IRQ      0xfb
> Please don't do this, or at least choose different numbers. 0xf3 is a
> valid MSI on p4080 (not to mention T4240 which goes beyond 256).

Ah, that's where I was wondering myself too. I copied the above logic from Linux, which maps tmr and ipi to max_irq-x. But I agree that it sounds off.

Yeah, Linux was buggy and has since been fixed (specifically, we turned on MPIC_LARGE_VECTORS so that max_irq is large enough to not conflict).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]