[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 14/19] openpic: convert to qdev

From: Scott Wood
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 14/19] openpic: convert to qdev
Date: Tue, 11 Dec 2012 11:47:42 -0600

On 12/11/2012 02:25:31 AM, Alexander Graf wrote:

On 11.12.2012, at 00:47, Scott Wood <address@hidden> wrote:

> On 12/08/2012 07:44:37 AM, Alexander Graf wrote:
>> This patch converts the OpenPIC device to qdev. Along the way it
>> renames the "openpic" target to "raven" and the "mpic" target to
>> "mpc8544", to better reflect the actual models they implement.
>> This way we have a generic OpenPIC device now that can handle
>> different flavors of the OpenPIC specification.
> I'd rather not see the expansion of "mpc8544" hardcoding, especially since it's not really modelling an MPIC as found in an mpc8544, but rather half-implementing a generic Freescale MPIC.

That's what we've been doing wrong all the time now. We shouldn't implement a half-generic fsl mpic, because we will never get to a point where we're accurate enough or flexible enough for both definitions.

What do you mean by "both"? AFAICT we'll always have a half-generic MPIC because we'll probably never get it looking 100% like any particular chip.

If we want a pv style generic mpic (for -M e500), let's add such an mpic to the model list and make that one be really generic. But the MPIC in -M mpc8544ds should behave exactly like an mpc8544 mpic. Whenever we fail to do so, we better fix the emulation to be accurate ;)

What behaviors would "mpc8544" specify that "fsl mpic v2.0" would not?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]