[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] target/mips: Restrict 'qapi-commands-machine.h' to syste

From: Richard Henderson
Subject: Re: [PATCH 3/4] target/mips: Restrict 'qapi-commands-machine.h' to system emulation
Date: Mon, 19 Dec 2022 15:58:41 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 12/19/22 13:10, Philippe Mathieu-Daudé wrote:
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
user-mode builds") we don't generate the "qapi-commands-machine.h"
header in a user-emulation-only build.

Extract the QMP functions from cpu.c (which is always compiled) to
the new 'sysemu/monitor.c' unit (which is only compiled when system
emulation is selected).

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
  target/mips/cpu.c              | 29 -------------------------
  target/mips/sysemu/meson.build |  1 +
  target/mips/sysemu/monitor.c   | 39 ++++++++++++++++++++++++++++++++++
  3 files changed, 40 insertions(+), 29 deletions(-)
  create mode 100644 target/mips/sysemu/monitor.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]