[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] target/loongarch: Restrict 'qapi-commands-machine.h' to

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/4] target/loongarch: Restrict 'qapi-commands-machine.h' to system emulation
Date: Tue, 20 Dec 2022 10:32:35 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1

On 20/12/22 00:58, Richard Henderson wrote:
On 12/19/22 13:10, Philippe Mathieu-Daudé wrote:
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
user-mode builds") we don't generate the "qapi-commands-machine.h"
header in a user-emulation-only build.

Extract the QMP functions from cpu.c (which is always compiled) to
the new 'cpu-monitor.c' unit (which is only compiled when system
emulation is selected).

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
  target/loongarch/cpu-monitor.c | 37 ++++++++++++++++++++++++++++++++++
  target/loongarch/cpu.c         | 27 -------------------------
  target/loongarch/meson.build   |  1 +
  3 files changed, 38 insertions(+), 27 deletions(-)
  create mode 100644 target/loongarch/cpu-monitor.c

Why cpu-monitor.c and not monitor.c like for target/arm/?

I figured later 'monitor.c' was simpler and renamed the other targets
but forgot to rename this one :/

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]