[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] target/ppc: Restrict 'qapi-commands-machine.h' to system

From: Richard Henderson
Subject: Re: [PATCH 4/4] target/ppc: Restrict 'qapi-commands-machine.h' to system emulation
Date: Mon, 19 Dec 2022 15:59:35 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 12/19/22 13:10, Philippe Mathieu-Daudé wrote:
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
user-mode builds") we don't generate the "qapi-commands-machine.h"
header in a user-emulation-only build.

Move the QMP functions from cpu_init.c (which is always compiled) to
monitor.c (which is only compiled when system-emulation is selected).
Note ppc_cpu_class_by_name() is used by both file units, so we expose
its prototype in "cpu-qom.h".

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
  target/ppc/cpu-qom.h  |  2 ++
  target/ppc/cpu_init.c | 48 +----------------------------------------
  target/ppc/monitor.c  | 50 ++++++++++++++++++++++++++++++++++++++++++-
  3 files changed, 52 insertions(+), 48 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]