[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 0/4] target-riscv: support vector extension part 1

From: Jim Wilson
Subject: Re: [PATCH v5 0/4] target-riscv: support vector extension part 1
Date: Wed, 26 Feb 2020 12:09:20 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/21/20 1:45 AM, LIU Zhiwei wrote:
This is the first part of v5 patchset. The changelog of v5 is only coverd
the part1.

   * support specification riscv-v-spec-0.7.1.

I'm still concerned about versioning issues. This implements an unofficial draft of the proposed RISC-V vector extension. This draft is not compatible with the current draft, and will be even less compatible with the final official version of the vector spec.

The patch adds a version which is good, but there is only one check when qemu starts. Probably something like 25% of these patches will be wrong for the official vector extension. How are we going to handle this when someone submits patches for the official support? It would be better if everything in these patches were conditional on the version number. It might also be better if we stopped calling this the 'v' extension and maybe used another name like Xrvv071 to make it clear that it is an unofficial draft of the proposed vector spec. Or maybe be we can use v0p7 but that isn't an officially supported extension name.

If this rvv 0.7.1 implementation is considered a temporary solution, maybe we can just remove all of this work when the official rvv spec if available? But presumably it is better if we can have both this implementation and the official one, which means everything needs to be conditional or tied to an Xsomething extension name instead of the V extension name.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]