[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is availab

From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header
Date: Fri, 29 Apr 2016 14:54:28 +0100

On 29 April 2016 at 14:07, Jan Vesely <address@hidden> wrote:
> Fixes build failure with --enable-xfsctl and
> new linux headers (>=4.5) and older xfsprogs(<4.5):
> In file included from /usr/include/xfs/xfs.h:38:0,
>                  from 
> /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:97:
> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
>  struct fsxattr {
>         ^
> In file included from 
> /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:60:0:
> /usr/include/linux/fs.h:155:8: note: originally defined here
>  struct fsxattr {
> CC: address@hidden
> CC: Markus Armbruster <address@hidden>
> CC: Peter Maydell <address@hidden>
> CC: Stefan Weil <address@hidden>
> Signed-off-by: Jan Vesely <address@hidden>
> ---
> One can argue that the failure only happens for invalid linux-headers,
> xfsprogs combinations, feel free to reject the patch in that case.
> This patch relies on functionality introduced in
> 559607ea173 io: add QIOChannelSocket class
>  configure | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

Hi; thanks for this patch. I'm a bit confused by it:

> +if test "$have_fsxattr" = "yes" ; then
> +    echo "HAVE_FSXATTR=y" >> $config_host_mak
> +fi

This means we'll build with a HAVE_FSXATTR define set, but
nothing in the tree tries to use that as far as I can tell:
"git grep HAVE_FSXATTR" returns no matches. What am I missing?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]