[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is availab

From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header
Date: Fri, 29 Apr 2016 15:49:56 +0100

On 29 April 2016 at 15:31, Stefan Weil <address@hidden> wrote:
> Is it a bug of the system headers? Or simply a design which
> requires users to be careful when including certain header files?
> Both /usr/include/xfs/xfs_fs.h and /usr/include/linux/fs.h define
> the same struct fsxattr, and both definitions are identical.

That sounds like a header bug to me...


suggests that (a) the xfsprogs folks are updating their
header to deal with what the kernel header is doing and that
(b) they think the distros ought to be updating both of them
in sync in some way...

> Of course a good comment would be helpful here, e. g.
> # Avoid redefinition of struct fsxattr in xfs/xfs_fs.h.
> # It is already defined in linux/fs.h.

Yes, this is really all I want: a note that some versions of
the kernel headers and the xfs headers clash, so we suppress
the xfs version if the kernel header is providing the struct.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]