speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/7] move module_audio_init from each module to the module_util.c


From: Andrei Kholodnyi
Subject: [PATCH 1/7] move module_audio_init from each module to the module_util.c
Date: Mon, 29 Nov 2010 21:11:27 +0100

> yes, maybe I should have been a little clearer. ?Even though the generic
> module doesn't use our audio system you still initialize an AudioID and
> setup some audio system which you never use. ?In addition this has the
> effect of making it look to the world like you successfully changed some
> audio parameters when in fact the changes you made have no effect
> because the audio setup you changed the parameters of isn't use for
> anything.

Hi Trev, sorry I didn't get your message.
As far as I understood it you want us to remove this dependency from generic?

> I think the way we already do this is reasonable. ?take a look at
> config/espeak-generic.conf for example.

yes, it uses $PLAY_COMMAND coming from spd_audio_get_playcmd.
this is the only dependency on audio subsystem generic module has

probably we can remove this call and set  $PLAY_COMMAND inside an
active audio plugin.
then we have no dependency on audio subsystem in this module anymore.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]