speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] determine availability of audio plugins by using config.h


From: William Hubbs
Subject: [PATCH] determine availability of audio plugins by using config.h
Date: Sun, 5 Dec 2010 12:33:15 -0600

Hi Andrei,

On Sun, Dec 05, 2010 at 06:47:25PM +0100, Bohdan R. Rau wrote:
> On Sun, 5 Dec 2010 10:27:25 -0600, William Hubbs <w.d.hubbs at gmail.com>
> wrote:
> [...]
> > I really would like to see us have config.h be the only generated source
> > file other than Makefiles, and this patch makes that possible.
> 
> I agree.

I believe that for easier maintenance, this patch is a better option
than what we are currently doing.

Yes, I agree that it adds #ifdefs in the c code, but I don't see a
problem with having them in this case. This keeps us from
generating a .c file in the configure step and limits what the configure
step touches to config.h and the makefiles, which brings us in line with
how the autotools are supposed to work imho.

Would you please re-consider your position on this patch?

Thanks,

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101205/2eeebd6c/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]