[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
autotools and ifdefs
From: |
Andrei Kholodnyi |
Subject: |
autotools and ifdefs |
Date: |
Sun, 5 Dec 2010 23:47:35 +0100 |
On Sun, Dec 5, 2010 at 10:07 PM, William Hubbs <w.d.hubbs at gmail.com> wrote:
> For things like this, I think we just have to be careful not to overdo
> it and not spread this through much of the code.
>
>> + ? ? if (!rate
>> +#ifdef HAVE_SAMPLERATE
>> + ? ? ? ? ? ? && !pitch
>> +#endif
>> + ? ? ? ? ? ? ) {
>
> ?This, on the other hand, I definitely disagree with. ?I do not agree
> ?with using #ifdef's to break up conditionals like this. It will
> ?definitely make things more difficult to maintain.
Yes, I meant this particular code snippet.
Since it was just a patch proposal, I wanted while giving a feedback
concentrate myself only on functionality provided by this patch,
But then due to #ifdef's discussion I have decided to highlight it.
Bohdan sorry for that :D
- [PATCH] determine availability of audio plugins by using config.h, (continued)
- [PATCH] determine availability of audio plugins by using config.h, William Hubbs, 2010/12/05
- [PATCH] determine availability of audio plugins by using config.h, Andrei Kholodnyi, 2010/12/05
- [PATCH] determine availability of audio plugins by using config.h, William Hubbs, 2010/12/05
- [PATCH] determine availability of audio plugins by using config.h, Andrei Kholodnyi, 2010/12/05
- [PATCH] determine availability of audio plugins by using config.h, William Hubbs, 2010/12/05
- [PATCH] determine availability of audio plugins by using config.h, Andrei . Kholodnyi, 2010/12/06
- [PATCH] determine availability of audio plugins by using config.h, Christopher Brannon, 2010/12/06
- [PATCH] determine availability of audio plugins by using config.h, Andrei Kholodnyi, 2010/12/06
- [PATCH] determine availability of audio plugins by using config.h, Andrei Kholodnyi, 2010/12/05
- autotools and ifdefs, William Hubbs, 2010/12/05
- autotools and ifdefs,
Andrei Kholodnyi <=
- autotools and ifdefs, Bohdan R . Rau, 2010/12/06
- autotools and ifdefs, Andrei Kholodnyi, 2010/12/06