libspeechd SPDVoice cleanup api

[Luke Yelavich]

On Sat, Oct 25, 2014 at 04:24:12PM EDT, Trevor Saunders wrote:
> > >> +void free_spd_voices(SPDVoice** voices)
> > >
> > > super picky, but wouldn't SPDVoice **voices be more consistant?
> 
> I see you left that, but I'm not going to hasle you about it given this
> code seems pretty inconsistant.

Yeah agreed, probably something that is worth cleaning up at some point.

> 
> > >> +{
> > >> +     int i = 0;
> > >> +     while (voices != NULL && voices[i] != NULL) {
> > >
> > > I'd say this function probably shouldn't accept a null voice list, or at
> > > least the check should be manually hoisted out of the loop.
> > 
> > Yep, removed the null check.
> > 
> > >
> > >> +             free(voices[i]->name);
> > >> +             free(voices[i]);
> > >> +             ++i;
> > >> +     }
> > >
> > > you could get rid of the extra variable and do
> > >
> > > for (; *voices; voices++) {
> > >   free((*voices)->name);
> > >   free(*voices);
> > > }
> > 
> > If I do this I wont be able to free voices afterwards. So I left that as is.
> 
> yeah, you caught me ;) lgtm now fwiw.

Also agreed, I'll apply.

Luke