[Tiger-devel] [PATCH] Speed improvement in deb_checkmd5sums

[Nicolas François]

Hello all,

Here are two patches that can improve speed of deb_checkmd5sums:

-- 18_deb_checkmd5sums_improve_speed_md5sums.patch ---------------------
Speed improvement in deb_checkmd5sums:
don't call md5sum for each lines of dpkg/info/*.md5sums files, but call
it with the whole .md5sums files (with little modifications)

Note 1: I didn't tested to create one big md5sums file because I did not
wanted to change the report of this script and thought that retrieving
the package name would take a long time with dpkg -S. I will try to test
it.
Note 2: The md5 sum could be added to the report when a file different
from debian's distribution change. (redundant with aide, integrit or
tripwire checks?)
Note 3: time: (s)    patch  nopatch
             user:     30    151
             system:   17    194
             CPU%:      8%    45%
             total:  8:35  12:50
------------------------------------------------------------------------

-- 19_deb_checkmd5sums_improve_speed_purged_locales.patch --------------
Another improvement to deb_checkmd5sums:
Don't calculate md5sum for purged locale files.

Note 1: need patch #18. Could be easily ported.
Note 2: need more tests? (I didn't use localepurge before)
Note 3: time         patch  nopatch
             user:     33      30
             system:   18      17
             CPU%:     10%      9%
             total:  8:05    8:35
------------------------------------------------------------------------


BTW, I tested a patch to use diversion:

-- 20_deb_checkmd5sums_diversions.patch --------------------------------
Add support for diversions. (old Debian bug #162589)

Note 1: Works for me, removed 6 false positive.
Note 2: time         patch  nopatch
             user:     41     33
             system:   19     18
             CPU%:     12%    10%
             total:  8:20   8:05
Note 3: Debian bug has the pending tag, but can't find corresponding
code in CVS, sorry if it's already fixed.
Note 4: tested with patches #18 and #19, but could easily be ported to
the CVS version (just ask if you want it).
------------------------------------------------------------------------

hth
-- 
Nekral

18_deb_checkmd5sums_improve_speed_md5sums.patch
Description: Text document

19_deb_checkmd5sums_improve_speed_purged_locales.patch
Description: Text document

20_deb_checkmd5sums_diversions.patch
Description: Text document