[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pull requests

From: Clément Pit-Claudel
Subject: Re: pull requests
Date: Fri, 27 Mar 2020 09:00:10 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 27/03/2020 03.54, Eli Zaretskii wrote:
> More importantly, given that I did a review
> of such a remote branch, how do I communicate my comments so that they
> are recorded for posterity?  Probably by email, so that doesn't seem
> to solve the main problem of avoiding email in the patch submission
> and review workflow.

Assuming you use the web UI, you can typically attach comments to code regions.

Pros over email reviews include the fact that the comments remain attached to 
the code even after the patch is updated (so if the original author updates an 
unrelated section of the patch the comments don't disappear) and the fact that 
you get to see the full code, rather than just the patch.

Cons include inferior text-editing capabilities, and inferior code browsing 
capabilities compared to applying the patch and browsing around in Emacs (but 
you can always checkout the branch, which I find nicer than applying patches by 
hand anyway).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]