Re: Thoughts about ax_resip.m4, anyone?

[Peter Johansson]

Peter Simons wrote:
> How you feel about adding this macro to the archive?
>
>
>   
Please encourage contributors to include a serial number in the .m4 
file. Also I think hard-coded ACTION-IF_FOUND/ACTION-iF_NOT_FOUND should 
be encouraged and rather they should be modifiable via the user 
interface for example as: MACRO([ACTION-IF-FOUND], 
[ACTION-IF-NOT-FOUND]) with a possible default behavior if the argument 
is left empty. Below follows some more comments:

>                 if test -f "$inc/libresip.so" || test -f "$inc/libresip.a"

Checking for `libresip.so' is not portable. On Darwin, for example, 
shared libraries are named *.dylib.

>         CPPFLAGS="$CPPFLAGS $RESIP_CPPFLAGS $CFLAGS"

Why using $CFLAGS when testing a test C++ library?

>         AC_TRY_LINK([#include <resip/stack/SipStack.hxx>],

AC_TRY_LINK is obsoleted and AC_LINK_IFELSE is to prefer.

>             AC_MSG_ERROR([[Could not detect the Resiprocate libraries.]])
>             AC_MSG_RESULT([no])
Why having any code after exit?



Thanks,
Peter

--
Peter Johansson

svndigest maintainer, http://dev.thep.lu.se/svndigest
yat maintainer,       http://dev.thep.lu.se/yat