Re: NSPathUtilities Patch - 2 - Win32

[Fred Kiefer]

Hi Sheldon,

the current state of this patches looks rather dubious to me. In the 
function Win32GetUserProfileDirectory an undeclared variable s (NSString 
*) is used and InitialisePathUtilities calles Win32Initialise 
unconditionally. This make me feel rather uneasy with the whole set of 
patches. Could you please retest the patch on a non Windows platform?

I would also suggest, that you drop the fancy stuff with the #pragma 
mark statements (or explain why you need them and the decoration around).

I did not follow the original discussion in every detail, but as far as 
I remember the suggestion was, that you split up your big patch in 
smaller ones to be reviewed and applied separatly. The current patch has 
been split up in different mails, but again may only be applied in one 
go. What about introducing the new Win32 functions (and removing obsolte 
functions and perhaps renaming the file) in one patch and doing the rest 
in separate patches?

Cheers
Fred