gnuherds-app-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: task 8833 -- steps 1 and 2


From: Davi Leal
Subject: Re: task 8833 -- steps 1 and 2
Date: Fri, 28 Nov 2008 23:07:33 +0100
User-agent: KMail/1.9.9

Federico Gimenez Nieto wrote:
> attached is the corrected patch (with two more things, modified droping
> table instruction and modified addDonation call inside Job_Offer.php) and
> the sql commands to modify the current database.

Updated patch attached. It adds at:


 Layer-0__Site_entry_point/doc/GNUHerds__SQL_Implementation.sql

  1) Proposed string modifications:
       * Donation pledge groups  -->  Donations for donation-pledge-groups.
       * To confirm donation  -->  To confirm the donation

  2) New line to make it easier to read.

  3) Table name fix:
       GRANT SELECT, INSERT, UPDATE, DELETE
       ... D1_Donations2JobOffers


 Layer-5__DB_operation/Job_Offer.php

  4) Proposed development rule: Use tabs instead of blanks for indentation.


 Layer-5__DB_operation/Donation.php

  5) Proposed modification; shorter and more clear:
       REQUEST_ADD_DONATION_TO_NOTICE_OPERATION --> REQUEST_TO_ADD_DONATION
       REQUEST_ADD_DONATION_TO_NOTICE_OPERATIO

 

Other modifications not included yet:
  REQUEST_ADD_NOTICE_OPERATION          --> REQUEST_TO_ADD_NOTICE
  REQUEST_SUBSCRIBE_TO_NOTICE_OPERATION --> REQUEST_TO_SUBSCRIBE_TO_NOTICE



What do you think?

Attachment: task-8833.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]