|
From: | Marc Hohl |
Subject: | Re: Add tab-tie-follow-engraver (issue2723043) |
Date: | Thu, 04 Nov 2010 09:31:27 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10 |
Am 03.11.2010 20:33, schrieb Carl Sorensen:
On 11/3/10 10:15 AM, "Marc Hohl"<address@hidden> wrote:Am 03.11.2010 15:10, schrieb Carl Sorensen:On 11/3/10 6:50 AM, "Marc Hohl"<address@hidden> wrote:Am 02.11.2010 04:04, schrieb address@hidden:Updated to only acknowledge tab-note-head, not note-head.Makes perfect sense to me. Thanks for your work!You're welcome. Pushed to git.Oops, I found an error! While my engraver added 'tie-follow only to the notes followed by a slur or a glissando, your engraver adds this to *every* tied note, so the callbacks in tablature.scm are not working properly - *every* note that is 'tied to' gets parenthesized! Moreover, Neil's argument that slurs and glissandos do not belong to the engraver seems not to be valid - every note that is 'tied to' now gets the 'tie-follow mark, so the tie handler will make them invisible and the slur routine that may follow changes the visibility again, and that's exactly what Neil critiziced at my first approach (and he was right about that).So perhaps what we need are 'tie-follow, 'slur-start, and 'gliss-start properties for a tab note head.
No, I don't think we should it do more complicated that necessary. Perhaps the name 'tie-follow is misleading, but the engraver (before you left out the slur and glissando bits) did the right job - marking exactly the tab-note-heads that have to be treated specially.If we mark *every* tied-to note, we have to mark *every* start of a slur and *every* start of a glissando as well and check for the appearance of (and ('tie-follow (or ( 'slur-start 'gliss-start)))), which is overkill - just let the engraver take the decision, raise a flag, and the callbacks do their job.
Marc
[Prev in Thread] | Current Thread | [Next in Thread] |