lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add tab-tie-follow-engraver (issue2723043)


From: Marc Hohl
Subject: Re: Add tab-tie-follow-engraver (issue2723043)
Date: Sun, 07 Nov 2010 10:24:28 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10

Am 07.11.2010 08:47, schrieb address@hidden:
This patch has revised the callbacks in scm/tablature.scm.  It appears
to work properly.

The tab-tie-follow-engraver is still using SCM calls to analyze the
grobs.  I will get that worked out soon, I hope (although I seem to have
gone backward, not forward, today).

In this patch, the glissando, slur, tie, and repeat-tie callbacks have
been modified.  The slur callback doesn't even check for the tie status,
since there's no change.
But it has to take the value of 'display-cautionary into account, isn't it?
The glissando callback checks to see if the
notehead has been forced to display with parentheses, but it does not
set the notehead display format.  The tie and repeat-tie callbacks are
responsible for setting the notehead display.

I think that this is the right logic.  Because the tie can be split, the
tie (and repeat-tie) callbacks need to decide on the note head display.
The slur and glissando callbacks don't need to set the display, they
just respond to it if need be.
+1

Marc

Thanks,

Carl


http://codereview.appspot.com/2723043/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]