[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Line breaks in @file{} entries?

From: Valentin Villenave
Subject: Re: Line breaks in @file{} entries?
Date: Fri, 26 Nov 2010 02:40:35 +0100

On Fri, Nov 26, 2010 at 1:11 AM, Graham Percival
<address@hidden> wrote:
> On Thu, Nov 25, 2010 at 07:30:20AM -0800, Mark Polesky wrote:
>> Can you post to Rietveld?  That's the preferred code sharing
>> location.

Let me see... A 300-Ko patch that affects >100 files? No way. I'm
barely able to upload a 15-lines patch...

> also, Rietveld isn't magic.  Google doesn't [yet, afaik at least]
> read your emails to determine if you like them or not, and cause
> rietveld to stop working for you if you dislike large commercial
> companies.

I dislike large commercial companies so much that I've just uploaded
my patch on a commercial file-sharing service. Yuck.

> If it doesn't work, then either there's something wonky with their
> servers, or with your client stuff.  What if you tried removing
> git-cl and/or your lilypond directory, and starting with a fresh
> git checkout and a new git-cl ?  What if you tried a new
> "throw-away" gmail account ?  etc.

I've updated my git-cl and config files, but that's about as far as
I'm willing to go.

> then again, -1.  At the moment, we're just at the "discussing
> policy" stage; seeing a patch which added or removed @/ in a
> thousand places doesn't help to clarify the discussion.

Certainly. That was just in case Mark would have been eager to address
this newline problem.

> I don't think that @/ is appropriate.  Certainly not for a short
> @file{filename.ext}.  I'm willing to entertain the notion of using
> them inside a @file{long/directory/location/with/filename.ext},
> although my preferred solution to those would be to put them in a
> separate @example or @smallexample.

Removing them is way easier than adding them (besides adding @/
everywhere, my commit actually _added_ quite a bunch of @file entries
whenever these were missing, e.g. in the CG. "programming work".

> Also, given the amount of docs which have never been reviewed with
> respect to the doc policy, I don't see this particular
> inconsistency as important.

I never said it was. Which is why I wanted to address it as quickly
and discretely as possible, and pushed it elsewhere than master.

> Given that the topic has been forced
> upon us,

I always appreciate the way you're putting things. If anything, me
working solo on this was *precisely* about letting serious people deal
with more important things.

I'd hate to see you being "forced" into anything. If that's the way
you see things, then just revert this commit already, get on with
proper development topics and quit making a fuss.

> I guess we might as well deal with it now, but please
> don't go searching around for other doc syntax stuff to ask about.
> A lot of people have been saving up other doc syntax
> inconsistencies until we have a chance to discuss them all in an
> organzied fashion.

This looked pretty harmless to me (to be honest, it still does). The
rationale was: if we're to decide that @/ can't be tolerated in @file
entries, removing these will be quite easy. If we decide, however,
that this is the way these must be written,... well, you get my point.

(And yes, I know, Lily's source code is no bloody wiki, yadda yadda.
C'mon, it's not like I'd use my git access to put pink unicorns on the
home page or rewrite the in LOLCODE -- not that I
haven't been tempted :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]