[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: LSR updates and Issue 1971

From: Graham Percival
Subject: Re: LSR updates and Issue 1971
Date: Fri, 25 Nov 2011 19:10:40 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Nov 25, 2011 at 05:59:04PM -0000, Phil Holmes wrote:
> I've got a large patch that updates the snippets from the LSR and
> fixes Issue 1971.  It's a few hundred files.  make and make doc are
> fine after adding it.  Should I push to staging or do something like
> a review - it seems unlikely anyone will have the enthusiasm to
> review all 300-odd changed files.


I'd personally prefer to split it into 2 separate commits:
1. run locally (i.e. don't point it at your tarball).

this will update the GIT_COMMITISH for every single file.  Quite
annoying, pollutes the history, but apparently translators need

if you skim over the patch in gitk, you shouldn't see anything
weird.  commit that and push directly to staging.

2. run and point at the downloaded LSR directory.

look at that patch more carefully, then please upload it for
review -- there should be 1-20 changed files.  Maybe 30.
we won't bother with a full countdown, but I'd like to skim it
before you push it.

- Graham

reply via email to

[Prev in Thread] Current Thread [Next in Thread]