Re: staging broken

[Ian Hulin]

On 06/01/12 12:38, Graham Percival wrote:
> hmm, I think I forgot to do something while reconfiguring my
> desktop.  Anyway, make doc fails.
> 
> I see **tons** of messages like
>   Defined "column-markup" function in #<directory (lily) 411399f0>
> which doesn't look like it should exist in production code.  It's
> certainly not helpful when trying to debug doc build failures.
> 
Those are temporary things for T2026 which will go when T1686 is
finished.  If these are causing you serious grief in the meantime I can
prepare another patch removing them all from markup-facility-defs.scm.
If so, do you want this done via another tracker?

> Seems to have failed in
> /main/large-tmp/lilypond-autobuild/Documentation/ly-examples/chart.ly
> can anybody build this "by hand" using current staging?
> 
It failed, but --loglevel=DEBUG tails shows:
Processing
`/home/ian/src/lilypond/build/out/share/lilypond/current/scm/../Documentation/ly-examples/chart.ly'
Parsing...
[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/init.ly
 
[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/declarations-init.ly

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/music-functions-init.ly]
  [/home/ian/src/lilypond/build/out/share/lilypond/current/ly/toc-init.ly
Defined "table-of-contents-markup-list" function in #<module b6a145d0>
Defined "make-table-of-contents-markup-list" function in #<module b6a145d0>
]
Using `nederlands' note names...

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/drumpitch-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/chord-modifiers-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/script-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/chord-repetition-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/scale-definitions-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/dynamic-scripts-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/spanners-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/predefined-fretboards-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/string-tunings-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/property-init.ly]
  [/home/ian/src/lilypond/build/out/share/lilypond/current/ly/grace-init.ly]
  [/home/ian/src/lilypond/build/out/share/lilypond/current/ly/midi-init.ly

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/performer-init.ly]]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/paper-defaults-init.ly

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/titling-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/text-replacements.ly]]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/context-mods-init.ly]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/engraver-init.ly]]
 
[/home/ian/src/lilypond/build/out/share/lilypond/current/scm/../Documentation/ly-examples/chart.ly

[/home/ian/src/lilypond/build/out/share/lilypond/current/scm/../Documentation/ly-examples/example-header.ily]

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/predefined-guitar-fretboards.ly
Using `nederlands' note names...

[/home/ian/src/lilypond/build/out/share/lilypond/current/ly/predefined-guitar-ninth-fretboards.ly]]]
Interpreting music...
[/home/ian/src/lilypond/build/out/share/lilypond/current/fonts/otf/emmentaler-20.otf]
Catching throw for unbound-variable condition
warning: Errors detected while processing
../Documentation/ly-examples/chart.ly

programming error: Parsed object should be dead: static
scm_unused_struct* Prob::mark_smob(SCM)
continuing, cross fingers
programming error: Parsed object should be dead: static
scm_unused_struct* Context_def::mark_smob(SCM)
continuing, cross fingers
programming error: Parsed object should be dead: static
scm_unused_struct* Context_mod::mark_smob(SCM)
continuing, cross fingers
programming error: Parsed object should be dead: static
scm_unused_struct* Lily_lexer::mark_smob(SCM)
continuing, cross fingers
Success: compilation successfully completed

The problem is fixed by adding make-simple-markup to the
(scm module-facility-def)'s interface like this

address@hidden ~/src/lilypond/build (T2026)$ git diff
diff --git a/scm/markup-facility-defs.scm b/scm/markup-facility-defs.scm
index 9131514..c7a68f9 100644
--- a/scm/markup-facility-defs.scm
+++ b/scm/markup-facility-defs.scm
@@ -23,13 +23,13 @@
   #:re-export-syntax (defmacro*-public)
   #:export        (markup?
                   markup-join
+                  make-simple-markup
                   compile-all-markup-expressions
                   compile-markup-expression)

   #:export-syntax (markup
                   define-markup-command
-                  define-markup-list-command
-                  markup* )
+                  define-markup-list-command)
   #:replace (markup))

 "
address@hidden ~/src/lilypond/build (T2026)$

the (define-public empty-markup) statement in define-markup-definitions
used make-simple-markup directly which is a macro defined during the
macro expansion of (define-markup-command (simple ... ) in
markup-facility-defs.  The other line change was to take out cruft
exporting the now-defunct markup* macro.

Running regression tests and document build now.

Graham, how do you want to handle this? Should I push a patch with this
mod. in addition to T2026 or re-submit the whole shebang?

> I also see errors like this:
> programming error: Parsed object should be dead: static
> scm_unused_struct* Prob::mark_smob(scm_unused_struct*)
> continuing, cross fingers
> programming error: Parsed object should be dead: static
> scm_unused_struct* Context_def::mark_smob(scm_unused_struct*)
> continuing, cross fingers
> programming error: Parsed object should be dead: static
> scm_unused_struct* Context_mod::mark_smob(scm_unused_struct*)
> continuing, cross fingers
> 
> anybody recognize what's happening?

These cropped up independently of T2026, after one of several
git pull/rebase cycles.

Cheers,
Ian