Re: FLAC ntohl patch (was Re: [Mingw-cross-env-list] Preparation of Release 2.16)

[Tony Theodore]

On 7 October 2010 11:53, Volker Grabsch <address@hidden> wrote:
> Tony Theodore <address@hidden> schrieb:
>> On 7 October 2010 02:46, DiAppoggio <address@hidden> wrote:
>> >
>> > Yes, I can bypass the patch adding -lwsock32 to ./configure , but I still
>> > don't understand why I need a networking library if I only need to encode a
>> > wav file into a flac one!
>>
>> My first thoughts also, it seems a bit silly. They use 'ntohl' on
>> non-windows systems, then implement their own 'local_swap32_'
>> conversion for windows (while still including winsock.h??) - I imagine
>> based on the assumption that it will always be little-endian.
>>
>> We can patch the build or patch the linking. Since bit manipulation
>> seems to be at the core of a compressor, I wouldn't be too confident
>> changing the bitreader/writer, and would rather just link in the
>> network lib. It's mostly too arcane for me though.
>
> I fully agree. Linking to wsock32 is the way to go.
>
> If we do otherwise (i.e. changing code), we shouldn't include it
> until we get it included into the official project.
>
> This takes more time than expected, but on the other hand, that's
> what the pre-release times are good for. :-)

Okay, i just committed the change adding wsock32 to *pc.in:

http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/745fd5c11879

Tony