[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -
From: |
OGAWA Hirofumi |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode |
Date: |
Thu, 15 Oct 2015 09:06:12 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
OGAWA Hirofumi <address@hidden> writes:
> Gerd Hoffmann <address@hidden> writes:
>
>> On Mi, 2015-10-14 at 20:37 +0900, OGAWA Hirofumi wrote:
>>> This converts vga code to curses code in console_write_bh().
>>>
>>> With this changes, we can see line graphics (for example, dialog uses)
>>> correctly.
>>
>> But it breaks line graphics in vga text mode on gtk I suspect?
>
> vga_to_curses[] is filled by curses_setup(). So if no -curses option, I
> think it should have no change to behavior. (BTW, there is no common
> section like kernel in qemu build, right? i.e. no need initializer to
> global value.)
The patch is following reply removes unnecessary
memset(vga_to_curses, 0, sizeof(vga_to_curses));
in curses_setup(). And tested line graphics works on both of gtk and curses.
Thanks.
--
OGAWA Hirofumi <address@hidden>
- [Qemu-devel] [RFC 0/3] improve/fix -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Eric Blake, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode,
OGAWA Hirofumi <=
- [Qemu-devel] [PATCH v2 1/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15