[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode |
Date: |
Thu, 15 Oct 2015 11:14:00 +0200 |
> > Also you don't need a init function, you can simply init the array with
> > c99 initializers:
> >
> > chtype vga_to_curses[256] = {
> > [0x04] = ACS_DIAMOND,
> > [ ... ]
> > };
>
> This is not possible, because ACS_* is not constant (initialized by
> reading from termcap or such).
Ah, ok. That isn't obvious from reading the code. Can you add a
comment please?
thanks,
Gerd
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, (continued)
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v4] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
Re: [Qemu-devel] [RFC 0/3] improve/fix -curses mode, Markus Armbruster, 2015/10/15