qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode
Date: Thu, 15 Oct 2015 11:14:00 +0200

> > Also you don't need a init function, you can simply init the array with
> > c99 initializers:
> >
> > chtype vga_to_curses[256] = {
> >     [0x04] = ACS_DIAMOND,
> >     [ ... ]
> > };
> 
> This is not possible, because ACS_* is not constant (initialized by
> reading from termcap or such).

Ah, ok.  That isn't obvious from reading the code.  Can you add a
comment please?

thanks,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]