[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode |
Date: |
Thu, 15 Oct 2015 11:13:11 +0200 |
Hi,
> From this call paths, graphic_hw_text_update() => console_write_ch() =>
> ->text_update() path is only used for -curses mode. What do you think?
Oh, right, text mode curses update and text mode framebuffer rendering
take completely separate code paths. Completely forgot that, I rarely
look into the curses code. Sorry for the extra trouble.
> (E.g. qemu is going to extend to use this for other purpose?)
Unlikely. In theory other ui frontends could support vga text mode that
way. But text mode is a dying relic, people use either graphics or a
serial console these days, so I don't expect that to happen.
So, I still think it would be cleaner to implement the curses special
char mapping in ui/curses.c. I can't imagine there is a noticable
performance difference. But doing it like you did shouldn't break
things either.
cheers,
Gerd
- [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, (continued)
- [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Eric Blake, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH v2 1/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v4] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
Re: [Qemu-devel] [RFC 0/3] improve/fix -curses mode, Markus Armbruster, 2015/10/15