[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] conditions variables module

From: Yoann Vandoorselaere
Subject: Re: [PATCH] conditions variables module
Date: Thu, 07 Aug 2008 17:02:56 +0200

Le jeudi 07 août 2008 à 11:15 +0200, Bruno Haible a écrit :
> > Attached is an initial implementation of the glcond module, based on
> > your lock module. 
> I like about it that its API is in the same spirit as 'lock' and 'tls'.
> A unit test and a Woe32 implementation are still missing.
> The prefix 'gl' for the module and header file is probably unnecessary:
> most modules are gnulib modules anyway, and if the header was called "cond.h",
> there would not be much risk of collision either.
> The comments still talk about "Locking" and me as the author.
> I would also mention in a comment the distinction between "condition variable"
> and "wait queue" done in [1].

Attached is an updated patch:

- Comments have been updated following your suggestion.

- I didn't modified the prefix yet, waiting for your reply to my
previous mail.

- Include a new glthread module (which doesn't handle sched_yield, since
that might pull another dependency in. I guess we need yet another
separate module for this one).

- Implement *basic* unit test for glthread_cond_wait() /

- Correct multiples condition bug with the PTH backend.


Attachment: gnulib-threads.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]