[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] conditions variables module

From: Bruno Haible
Subject: Re: [PATCH] conditions variables module
Date: Fri, 8 Aug 2008 00:01:45 +0200
User-agent: KMail/1.5.4

Hi Yoann,

> I'm not competent to write the Win32 implementation unfortunately. Will
> you be able to do this part of the work?

Yes. Win32 has the necessary primitives, it's only a matter of looking them
up... I can do that.

> > The prefix 'gl' for the module and header file is probably unnecessary:
> > most modules are gnulib modules anyway, and if the header was called 
> > "cond.h",
> > there would not be much risk of collision either.
> From experience, I'd prefer to avoid possible collision. Not that I ever
> met a system defining cond.h, but rather that I find it to be a good
> habit to have a generic prefix for this kind of stuff. I prefer
> preventing potential issue than curing them afterwise.
> Is that a problem to you?

It's not a big problem. But when we have a family of 4 modules, it would be
strange if they would use different conventions for the header files. - I used
the prefix 'gl_' in the ordered lists and sets modules, because I did not
dare to call a header file "list.h". But "cond.h" should be fine. For your
4th module, however, "thread.h" would collide with the Solaris <thread.h>.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]